Backport 26994 ([ownership] Fix key algo comparison hardening) #29260
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used XOR for the comparison hardening, but didn't realize that might flip false to true. Luckily, the allowed values checked before calling the function makes the flip impossible. This commit changes to normal comparison to eliminating the corner case. Change-Id: I7e4c7cdfd3d53a70852ecf97939fdce56a7b0cd8 Signed-off-by: Yi-Hsuan Deng <[email protected]> (cherry picked from commit 4da7fb1)
pamaury
requested review from
cfrantz,
jwnrt and
timothytrippel
and removed request for
a team
timothytrippel
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26994